<html>
<head><meta charset="utf-8"><title>bors on rust-analyzer · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html">bors on rust-analyzer</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="158115908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158115908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158115908">(Feb 12 2019 at 13:11)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="133169">@matklad</span> when I skimmed over other PR's to infer what the review-protocol was, I noticed a bunch have bors commenting "<strong>canceled</strong>"</p>



<a name="158115937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158115937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158115937">(Feb 12 2019 at 13:11)</a>:</h4>
<p>and they also, I think, all happened to have a <span aria-label="robot" class="emoji emoji-1f916" role="img" title="robot">:robot:</span> in the comment below where you had written "bors r+" (example <a href="https://github.com/rust-analyzer/rust-analyzer/pull/802#issuecomment-462705256" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/pull/802#issuecomment-462705256">here</a>)</p>



<a name="158116000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116000">(Feb 12 2019 at 13:12)</a>:</h4>
<p>so my question is: is that just a coincidence? Or are you adding in the robot as a way to cause the cancellation? Or is bors adding it in when it cancels the r+ of a PR?</p>



<a name="158116300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116300">(Feb 12 2019 at 13:17)</a>:</h4>
<p>and more generally, what is the bors "cancelled" signalling there? is the CI hitting some issue and forcing a retry, and thus in general it is not (necessarily) a sign that one might need to adjust one's PR in some manner? The "Canceled" comment doesn't include a link so its hard for me to tell where I would go to learn more</p>



<a name="158116441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116441">(Feb 12 2019 at 13:19)</a>:</h4>
<p>The <span aria-label="robot" class="emoji emoji-1f916" role="img" title="robot">:robot:</span> thing is my local script which sends a PR and r+ it immediately. I want even the smallest changes to go via bors, but I don't want to open the browser for each small commit.</p>



<a name="158116496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116496">(Feb 12 2019 at 13:20)</a>:</h4>
<p>Gotcha</p>



<a name="158116517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116517">(Feb 12 2019 at 13:20)</a>:</h4>
<p>As it happens, I am pretty bad with making good commits from the first try so often after I've done the <span aria-label="robot" class="emoji emoji-1f916" role="img" title="robot">:robot:</span> thing I notice that something is wrong and go with <code>git commit --amend &amp;&amp; git push --force-with-lease</code></p>



<a name="158116534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116534">(Feb 12 2019 at 13:21)</a>:</h4>
<p>That causes bors to cancel the current build,</p>



<a name="158116589"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116589" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116589">(Feb 12 2019 at 13:22)</a>:</h4>
<p>ah, so the cancellation is in response to the <code>git push --force</code> (or at least <code>--force-with-lease</code>)</p>



<a name="158116594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/bors%20on%20rust-analyzer/near/158116594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/bors.20on.20rust-analyzer.html#158116594">(Feb 12 2019 at 13:22)</a>:</h4>
<p>gotcha</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>